Upgrade flask-appbuilder to 4.6.3 in FAB provider#50513
Conversation
vincbeck
force-pushed
the
vincbeck/fab-upgrade
branch
4 times, most recently
from
ab3b034 to
7becd6d
Compare
potiuk
left a comment
potiuk
left a comment
There was a problem hiding this comment.
Looks good. Do I understand correctly, that we are adding the models but NOT running the migration for FAB and not creating the models - and we are not using the "Groups" feature at all ?
Or they will be created automatically somehow?
You are correct, we are not using the groups feature. Though, I updated the models using new tables such as |
vincbeck
force-pushed
the
vincbeck/fab-upgrade
branch
from
7becd6d to
c6aaa8c
Compare
Hmm.. Maybe Fab auto-migrates the models ? |
Maybe |
But on the other end it makes sense, we do not have migration defining FAB related tables. FAB handles it itself. When you reset the DB, the tables are automatically created even though we do not have migration for it. Same thing applies here with the new tables |
(cherry picked from commit e6430c2)
2 participants
Resolves #50187.
I vendored in Flask-appbuilder code needed by comparing flask-appbuilder 4.5.3 and 4.6.3.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.